patacongo commented on a change in pull request #1661:
URL: https://github.com/apache/incubator-nuttx/pull/1661#discussion_r479656905
##########
File path: include/netpacket/bluetooth.h
##########
@@ -286,6 +271,13 @@ struct sockaddr_bt_s
uint8_t bt_channel; /* Channel identifier (CID) */
};
+struct sockaddr_hci_s
+{
+ sa_family_t hci_family;
+ uint8_t hci_dev;
+ uint8_t hci_channel;
+};
+
Review comment:
> Does this matter?
This really raises the general question of "How close should the NuttX
Bluetooth socket interface match the Linux Bluetooth socket interface?"
1. Should Linux code just drop in with no changes other than perhaps header
file paths?
2. Or should re-use of Linux code require adjusting to NuttX naming
conventions like sockaddr_hci -> sockaddr_hci_s?
3. Or are we just aiming to be similar in spirit with Linux so that the port
is easy?
The first option might set the expectation too high. I think the NuttX
implementation will (and correctly should) always be lightweight compared to
the Linux implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
