v01d commented on pull request #1661: URL: https://github.com/apache/incubator-nuttx/pull/1661#issuecomment-690336068
I'm trying to follow where these changes are going, to understand how to adapt the ATT layer. I see that an L2CAP socket will do: bluetooth_send -> bluetooth_l2cap_send -> psock_bluetooth_sendto -> netdev TX queue (bluetooth_sendto_eventhandler) -> radio->r_req_data (btnet_req_data) -> bt_l2cap_send -> bt_conn_send whereas the ATT layer calls directly into `bt_l2cap_send`. I'm guessing this is the point where the socket should be used. However, at this point the ATT layer uses a `bt_conn_s` to identify a given connection. I imagine that replacing this with just the socket fd would be enough. Does that sound right to you? What confuses me is that on btnet_req_data it appears to try to create a connection before sending (https://github.com/apache/incubator-nuttx/blob/master/wireless/bluetooth/bt_netdev.c#L906). I'm a bit concerned since the net layer is introducing a second buffer queue, separate from the one used by the HCI layer. We should see if we're not loosing performance or wasting resources eventually. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
