jlaitine commented on code in PR #16673:
URL: https://github.com/apache/nuttx/pull/16673#discussion_r2185684622
##########
sched/sched/sched_setpriority.c:
##########
@@ -223,29 +230,30 @@ static inline void nxsched_running_setpriority(FAR struct
tcb_s *tcb,
/* A context switch will occur. */
#ifdef CONFIG_SMP
- if (tcb->cpu != this_cpu() &&
+ int cpu = this_cpu();
+ if (tcb->cpu != cpu &&
tcb->task_state == TSTATE_TASK_RUNNING)
{
- struct reprioritize_arg_s arg;
+ struct reprioritize_arg_s *arg = &g_reprioritize_arg[cpu];
Review Comment:
note to self: This needs to work the other way around; global argument
vector needs to be indexed with target cpu. Same task could do several priority
sets in a row for different tasks on other CPUs. Also the priority should be
set directly on the TCB already here so that reprioritize commands for
different tasks on the same CPU are not lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
