JianyuWang0623 commented on code in PR #3003:
URL: https://github.com/apache/nuttx-apps/pull/3003#discussion_r1964833572
##########
system/fastboot/fastboot.c:
##########
@@ -770,6 +784,41 @@ static void fastboot_filedump(FAR struct fastboot_ctx_s
*context,
fastboot_okay(context, "");
}
+#ifdef CONFIG_SYSTEM_FASTBOOTD_SH
+static void fastboot_sh(FAR struct fastboot_ctx_s *context,
+ FAR const char *arg)
+{
+ int ret;
+
+ ret = system(arg);
Review Comment:
OK, and maybe we need send "INFO" or "TEXT" response to make sure the entire
output from the command was sent instead of "OKAY"(no greater than 256 bytes.).
https://android.googlesource.com/platform/system/core/+/refs/heads/main/fastboot/README.md#transport-and-framing
##########
system/fastboot/fastboot.c:
##########
@@ -770,6 +784,41 @@ static void fastboot_filedump(FAR struct fastboot_ctx_s
*context,
fastboot_okay(context, "");
}
+#ifdef CONFIG_SYSTEM_FASTBOOTD_SH
+static void fastboot_sh(FAR struct fastboot_ctx_s *context,
+ FAR const char *arg)
+{
+ int ret;
+
+ ret = system(arg);
Review Comment:
@xiaoxiang781216 OK, and maybe we need send "INFO" or "TEXT" response to
make sure the entire output from the command was sent instead of "OKAY"(no
greater than 256 bytes.).
https://android.googlesource.com/platform/system/core/+/refs/heads/main/fastboot/README.md#transport-and-framing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
