xiaoxiang781216 commented on code in PR #3003:
URL: https://github.com/apache/nuttx-apps/pull/3003#discussion_r1964784830
##########
system/fastboot/Kconfig:
##########
@@ -32,4 +32,12 @@ config SYSTEM_FASTBOOTD_USB_BOARDCTL
---help---
Connect usbdev before running fastboot daemon.
+config SYSTEM_FASTBOOTD_SH
Review Comment:
```suggestion
config SYSTEM_FASTBOOTD_SHELL
```
##########
system/fastboot/fastboot.c:
##########
@@ -770,6 +784,41 @@ static void fastboot_filedump(FAR struct fastboot_ctx_s
*context,
fastboot_okay(context, "");
}
+#ifdef CONFIG_SYSTEM_FASTBOOTD_SH
+static void fastboot_sh(FAR struct fastboot_ctx_s *context,
+ FAR const char *arg)
+{
+ int ret;
+
+ ret = system(arg);
+ if (ret < 0)
+ {
+ fastboot_fail(context, "Create child process failed %d error %d",
+ ret, errno);
+ return;
+ }
+ else if (ret == 0 && arg == NULL)
Review Comment:
```suggestion
else if (ret == 0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
