xiaoxiang781216 commented on code in PR #3003:
URL: https://github.com/apache/nuttx-apps/pull/3003#discussion_r1963832263
##########
system/fastboot/fastboot.c:
##########
@@ -200,7 +207,10 @@ static const struct fastboot_cmd_s g_fast_cmd[] =
static const struct fastboot_cmd_s g_oem_cmd[] =
{
{ "filedump", fastboot_filedump },
- { "memdump", fastboot_memdump }
+ { "memdump", fastboot_memdump },
+#ifdef CONFIG_SYSTEM_FASTBOOTD_MKRD
+ { "mkrd", fastboot_mkrd },
Review Comment:
even that it's still better to invoke system("mkrd...")(or popen to get the
output), you can add a white list and check it before invoking system/popen, so
you don't need duplicate the parse code and extend the new command easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
