JianyuWang0623 commented on code in PR #3003:
URL: https://github.com/apache/nuttx-apps/pull/3003#discussion_r1963067653
##########
system/fastboot/fastboot.c:
##########
@@ -200,7 +207,10 @@ static const struct fastboot_cmd_s g_fast_cmd[] =
static const struct fastboot_cmd_s g_oem_cmd[] =
{
{ "filedump", fastboot_filedump },
- { "memdump", fastboot_memdump }
+ { "memdump", fastboot_memdump },
+#ifdef CONFIG_SYSTEM_FASTBOOTD_MKRD
+ { "mkrd", fastboot_mkrd },
Review Comment:
@xiaoxiang781216
1. Invoke `system()` directly may be too open for bootloader.
2. No other application scenarios except "sh mkrd" currently.
3. The function overlaps with ADB shell service (Althouth Fastboot and ADB
can not be enabled at the same time at present)..
So, I want to be cautious and narrow the scope to only implement the
necessary "mkrd" function ;-)
Will add support for oem sh to execute custom commands if it is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
