xiaoxiang781216 commented on PR #14865:
URL: https://github.com/apache/nuttx/pull/14865#issuecomment-2500186436

   > > not all arch need call up_set_interrupt_context. For example, all 
cortex-m just need read IPSR to detect the context, but the updating is done by 
hardware.
   > 
   > so, why we define up_set_interrupt_context() in common arm_internal.h not 
chip specific include/*/irq.h?
   
   since set_interrupt_context is only be called inside arch specific code, 
it's better to name arm_set_interrupt_context  and move into arm_internal.h 
like other arch specific functions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to