anchao commented on PR #14865: URL: https://github.com/apache/nuttx/pull/14865#issuecomment-2496493453
I didn't see any optimization of the current code in this PR. It's just a renaming of the APIs. up_set_current_regs / up_current_regs -> up_interrupt_context / arm_set_irq_flag Moreover, the new naming is even more difficult to understand than before. The naming and improvement of APIs need to be consider carefully, because many independent developers don't accept revolutionary API changes in every version. The "current_regs" has existed in NuttX for many years. Please don't randomly change the APIs if there is no substantial change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
