hujun260 commented on code in PR #14865:
URL: https://github.com/apache/nuttx/pull/14865#discussion_r1855757352


##########
arch/arm/src/dm320/dm320_decodeirq.c:
##########
@@ -109,11 +102,9 @@ uint32_t *arm_decodeirq(uint32_t *regs)
             }
 #endif
 
-          /* Set current_regs to NULL to indicate that we are no longer in
-           * an interrupt handler.
-           */
+          /* Set irq flag */
 
-          up_set_current_regs(NULL);
+          arm_set_irq_flag(false);

Review Comment:
   The size of bool is smaller, and its meaning is more clearer here



##########
arch/arm/src/arm/arm_dataabort.c:
##########
@@ -70,15 +70,14 @@ void arm_dataabort(uint32_t *regs, uint32_t far, uint32_t 
fsr)
 {
   struct tcb_s *tcb = this_task();
 #ifdef CONFIG_LEGACY_PAGING
-  uint32_t *savestate;
+  bool savestate;
+  uint32_t *saveregs;

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to