gosonzhang commented on code in PR #7170:
URL: https://github.com/apache/inlong/pull/7170#discussion_r1063178361
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/es/ElasticsearchDataNodeDTO.java:
##########
@@ -85,8 +85,8 @@ public static ElasticsearchDataNodeDTO getFromJson(@NotNull
String extParams) {
try {
return JsonUtils.parseObject(extParams,
ElasticsearchDataNodeDTO.class);
} catch (Exception e) {
- LOGGER.error("Failed to extract additional parameters for
Elasticsearch data node: ", e);
Review Comment:
The modification of this place is to allow the caller to analyze the
problem, rather than the system administrator to go to the log to analyze the
problem
Specifically for this error, the error is the parameter decoding error of
extParams, mainly two types, one is that the data passed by the caller is not
in json format, and the other is the content of the class that does not match
the class specified by the parser.
As the caller, it is clear what content is passed. Based on this basis, the
error code and error information provided by the assistant are very clear about
which field has an error. Through the specified parsing error information and
the original data of the call, the call The operator can analyze the problem by
himself, without the need for the system maintainer to view the log, that is,
this log output is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
