healchow commented on code in PR #7170:
URL: https://github.com/apache/inlong/pull/7170#discussion_r1063052302
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/openapi/OpenDataNodeController.java:
##########
@@ -71,24 +70,21 @@ public Response<List<DataNodeInfo>> list(@RequestBody
DataNodePageRequest reques
@PostMapping(value = "/node/save")
@ApiOperation(value = "Save node")
@OperationLog(operation = OperationType.CREATE)
- @RequiresRoles(value = UserRoleCode.ADMIN)
- public Response<Integer> save(@Validated @RequestBody DataNodeRequest
request) {
+ public Response<Integer> save(@Validated(SaveValidation.class)
@RequestBody DataNodeRequest request) {
return Response.success(dataNodeService.save(request,
LoginUserUtils.getLoginUser()));
}
@PostMapping(value = "/node/update")
- @OperationLog(operation = OperationType.UPDATE)
@ApiOperation(value = "Update data node")
- @RequiresRoles(value = UserRoleCode.ADMIN)
Review Comment:
Excuse me, but why remove the roles check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
