healchow commented on code in PR #7170:
URL: https://github.com/apache/inlong/pull/7170#discussion_r1063051079


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/es/ElasticsearchDataNodeDTO.java:
##########
@@ -85,8 +85,8 @@ public static ElasticsearchDataNodeDTO getFromJson(@NotNull 
String extParams) {
         try {
             return JsonUtils.parseObject(extParams, 
ElasticsearchDataNodeDTO.class);
         } catch (Exception e) {
-            LOGGER.error("Failed to extract additional parameters for 
Elasticsearch data node: ", e);

Review Comment:
   Does the `e.getMessage()` show the detail of the parse error? Such as which 
field was parsed failed.
   
   If not, then I think this error log is necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to