healchow commented on code in PR #7170:
URL: https://github.com/apache/inlong/pull/7170#discussion_r1063173081
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/es/ElasticsearchDataNodeDTO.java:
##########
@@ -85,8 +85,8 @@ public static ElasticsearchDataNodeDTO getFromJson(@NotNull
String extParams) {
try {
return JsonUtils.parseObject(extParams,
ElasticsearchDataNodeDTO.class);
} catch (Exception e) {
- LOGGER.error("Failed to extract additional parameters for
Elasticsearch data node: ", e);
Review Comment:
I did not understand that "If it fails, the caller will provide the specific
content."
This extParams parameter is saved in the DB. In case of wrong saving in the
DB, or the target conversion class changes, which leads to parsing failure, can
you get the specific information of extParams from "e.getMessage"?
If you can't get it, you need to check the specific information in the DB
according to the previous series of logs. This is undoubtedly more difficult.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
