[GitHub] [inlong] gong commented on a diff in pull request #7062: [INLONG-7061][Sort] Support table level metrics for Apache Doris connector and add dirty metrics

[GitBox]

gong commented on code in PR #7062:
URL: https://github.com/apache/inlong/pull/7062#discussion_r1057480671


##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisDynamicSchemaOutputFormat.java:
##########
@@ -512,17 +512,12 @@ private void handleDirtyData(Object dirtyData, DirtyType 
dirtyType, Exception e)
             }
         }
 
-        if (multipleSink && !DirtyType.DESERIALIZE_ERROR.equals(dirtyType) && 
dirtyData instanceof RowData) {
-            JsonNode rootNode;
-            try {
-                rootNode = jsonDynamicSchemaFormat.deserialize(((RowData) 
dirtyData).getBinary(0));
-                metricData.outputDirtyMetricsWithEstimate(
-                        jsonDynamicSchemaFormat.parse(rootNode, 
databasePattern),
-                        null, jsonDynamicSchemaFormat.parse(rootNode, 
tablePattern), rowSize, dataSize);
-            } catch (Exception ex) {
-                metricData.invokeDirty(rowSize, dataSize);
-            }
-        } else {
+        try {
+            JsonNode rootNode = jsonDynamicSchemaFormat.deserialize(((RowData) 
dirtyData).getBinary(0));
+            metricData.outputDirtyMetricsWithEstimate(
+                    jsonDynamicSchemaFormat.parse(rootNode, databasePattern),
+                    null, jsonDynamicSchemaFormat.parse(rootNode, 
tablePattern), rowSize, dataSize);

Review Comment:
   rowSize and dataSize should be rowSize = 1 and dataSize is byte length of 
dirtyData



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org