yunqingmoswu commented on code in PR #7062:
URL: https://github.com/apache/inlong/pull/7062#discussion_r1057111822


##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisDynamicSchemaOutputFormat.java:
##########
@@ -486,6 +497,17 @@ private void handleDirtyData(Object dirtyData, DirtyType 
dirtyType, Exception e)
             }
             throw ex;
         }
+
+        if (multipleSink) {

Review Comment:
   It is suggest to send the metic after the dirty data sink because the dirty 
sink maybe failed.



##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisDynamicSchemaOutputFormat.java:
##########
@@ -486,6 +497,17 @@ private void handleDirtyData(Object dirtyData, DirtyType 
dirtyType, Exception e)
             }
             throw ex;
         }
+
+        if (multipleSink) {
+            String[] tableWithDb = tableIdentifier.split("\\.");

Review Comment:
   It is not right because of the tableIdentifer is dynamic when it it 
multiplesink.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to