[GitHub] [inlong] gong commented on a diff in pull request #7062: [INLONG-7061][Sort] Support table level metrics for Apache Doris connector and add dirty metrics

[GitBox]

gong commented on code in PR #7062:
URL: https://github.com/apache/inlong/pull/7062#discussion_r1057478793


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/sub/SinkTableMetricData.java:
##########
@@ -199,6 +199,25 @@ public void outputMetricsWithEstimate(String database, 
String schema, String tab
         subSinkMetricData.invoke(rowCount, rowSize);
     }
 
+    public void outputDirtyMetricsWithEstimate(String database, String schema, 
String table, boolean isSnapshotRecord,
+            long rowCount, long rowSize) {
+        if (StringUtils.isBlank(database) || StringUtils.isBlank(table)) {
+            invokeDirty(rowCount, rowSize);
+            return;

Review Comment:
   lost `StringUtils.isBlank(schema)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org