[GitHub] [inlong] gong commented on a diff in pull request #7062: [INLONG-7061][Sort] Support table level metrics for Apache Doris connector and add dirty metrics

[GitBox]

gong commented on code in PR #7062:
URL: https://github.com/apache/inlong/pull/7062#discussion_r1057176958


##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisDynamicSchemaOutputFormat.java:
##########
@@ -503,6 +511,20 @@ private void handleDirtyData(Object dirtyData, DirtyType 
dirtyType, Exception e)
                 LOG.warn("Dirty sink failed", ex);
             }
         }
+
+        if (multipleSink) {
+            if (DirtyType.DESERIALIZE_ERROR.equals(dirtyType) || !(dirtyData 
instanceof RowData)) {
+                metricData.outputDirtyMetricsWithEstimate(null, null, null, 
rowSize, dataSize);

Review Comment:
   why not to pass databse table ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org