fuweng11 commented on code in PR #7001:
URL: https://github.com/apache/inlong/pull/7001#discussion_r1056017176
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/stream/InlongStreamServiceImpl.java:
##########
@@ -514,12 +569,31 @@ public Boolean updateWithoutCheck(InlongStreamRequest
request, String operator)
// update stream fields
updateField(groupId, streamId, request.getFieldList());
// update stream extension infos
- saveOrUpdateExt(groupId, streamId, request.getExtList());
+ List<InlongStreamExtInfo> extList = request.getExtList();
+ saveOrUpdateExt(groupId, streamId, extList);
LOGGER.info("success to update inlong stream without check for
groupId={} streamId={}", groupId, streamId);
return true;
}
+ /**
+ * Pack extended attributes into ExtParams
+ *
+ * @param request the request
+ * @return the packed extParams
+ */
+ private String packExtParams(InlongStreamRequest request) {
+ InlongStreamExtParamBuilder builder = InlongStreamExtParam.builder();
Review Comment:
It is recommended to use `CommonBeanUtils.copyProperties(request,
InlongStreamExtParam::new, true);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
