fuweng11 commented on code in PR #7001:
URL: https://github.com/apache/inlong/pull/7001#discussion_r1056019234
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/stream/InlongStreamServiceImpl.java:
##########
@@ -385,6 +424,16 @@ public PageResult<InlongStreamInfo>
listAll(InlongStreamPageRequest request) {
return pageResult;
}
+ private void unpackExtParams(InlongStreamInfo streamInfo) {
+ String extParams = streamInfo.getExtParams();
Review Comment:
It seems that there is a method with the same function in line 244. It is
recommended to unify the two methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
