fuweng11 commented on code in PR #7001:
URL: https://github.com/apache/inlong/pull/7001#discussion_r1056068132
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/stream/InlongStreamServiceImpl.java:
##########
@@ -514,12 +562,25 @@ public Boolean updateWithoutCheck(InlongStreamRequest
request, String operator)
// update stream fields
updateField(groupId, streamId, request.getFieldList());
// update stream extension infos
- saveOrUpdateExt(groupId, streamId, request.getExtList());
+ List<InlongStreamExtInfo> extList = request.getExtList();
+ saveOrUpdateExt(groupId, streamId, extList);
LOGGER.info("success to update inlong stream without check for
groupId={} streamId={}", groupId, streamId);
return true;
}
+ /**
+ * Pack extended attributes into ExtParams
+ *
+ * @param request the request
+ * @return the packed extParams
+ */
+ private String packExtParams(InlongStreamRequest request) {
Review Comment:
It is recommended to put it in the class `inlongStreamExtParam`.
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/stream/InlongStreamServiceImpl.java:
##########
@@ -226,6 +240,27 @@ public InlongStreamInfo get(String groupId, String
streamId) {
return streamInfo;
}
+ /**
+ * Unpack extended attributes from {@link InlongStreamExtInfo}, will
remove target attributes from it.
+ *
+ * @param extParams the {@link InlongStreamEntity} load from db
+ * @param targetObject the targetObject with to fill up
+ */
+ private void unpackExtParams(
Review Comment:
It is recommended to put it in the class `inlongStreamExtParam`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
