healchow commented on code in PR #7001:
URL: https://github.com/apache/inlong/pull/7001#discussion_r1054126585
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/tubemq/TubeMQSourceOperator.java:
##########
@@ -107,6 +107,8 @@ public Map<String, List<StreamSource>>
getSourcesMap(InlongGroupInfo groupInfo,
tubeMQSource.setTopic(streamInfo.getMqResource());
tubeMQSource.setGroupId(streamId);
tubeMQSource.setMasterRpc(masterRpc);
+ tubeMQSource.setSerializationType(streamInfo.getDataType());
+
Review Comment:
Why TubeMQ source not add setIgnoreFormatParseError?
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/source/StreamSource.java:
##########
@@ -110,6 +110,9 @@ public abstract class StreamSource extends StreamNode {
@ApiModelProperty("Sub source information of existing agents")
private List<SubSourceDTO> subSourceList;
+ @ApiModelProperty(value = "Whether ignore deserialization error, true as
default")
+ private boolean ignoreFormatParseError;
Review Comment:
```suggestion
ignoreParseError
@ApiModelProperty(value = "Whether to ignore the parse errors of field
value, true as default")
private boolean ignoreParseError;
```
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/stream/InlongStreamInfo.java:
##########
@@ -42,6 +42,7 @@
@ApiModel("Inlong stream info")
public class InlongStreamInfo extends BaseInlongStream {
+ private static final int DEFAULT_ENABLE_VALUE = 1;
Review Comment:
Suggest moving to `InlongConstants`.
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/stream/InlongStreamInfo.java:
##########
@@ -127,6 +128,13 @@ public class InlongStreamInfo extends BaseInlongStream {
@ApiModelProperty(value = "Version number")
private Integer version;
+ @ApiModelProperty(value = "Whether ignore deserialization error, 0: no, 1:
yes (as default)")
+ private Integer formatIgnoreParseError;
Review Comment:
```suggestion
@ApiModelProperty(value = "Whether to ignore the parse errors of field
value, 0: no, 1: yes (as default)")
private Integer ignoreParseError;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
