danny0405 commented on code in PR #13830:
URL: https://github.com/apache/hudi/pull/13830#discussion_r2320680075
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -638,7 +637,7 @@ public static <R> HoodieData<HoodieRecord<R>>
tagGlobalLocationBackToRecords(
}
});
return shouldUpdatePartitionPath
- ? mergeForPartitionUpdatesIfNeeded(incomingRecordsAndLocations,
config, table)
+ ? mergeForPartitionUpdatesIfNeeded(incomingRecordsAndLocations,
config, table, readerContext, writerSchema)
Review Comment:
The method `mergeForPartitionUpdatesIfNeeded` function beyonds its name
now(not just for checking partiton updates but also for a duplicate updates
check and out-of-order deletes update check), might need to give it a better
name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
