yihua commented on code in PR #13830:
URL: https://github.com/apache/hudi/pull/13830#discussion_r2319813075
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -638,7 +637,7 @@ public static <R> HoodieData<HoodieRecord<R>>
tagGlobalLocationBackToRecords(
}
});
return shouldUpdatePartitionPath
- ? mergeForPartitionUpdatesIfNeeded(incomingRecordsAndLocations,
config, table)
+ ? mergeForPartitionUpdatesIfNeeded(incomingRecordsAndLocations,
config, table, readerContext, writerSchema)
Review Comment:
`shouldUpdatePartitionPath` can be set to false (if
`hoodie.record.index.update.partition.path=false` or the table is
non-partitioned) so `mergeForPartitionUpdatesIfNeeded` is skipped. For proper
handing deletes with lower ordering value (i.e., deletes that should not take
effect), the merging of incoming records and existing records on storage needs
to be invoked. Thus the condition here needs to be updated?
@nsivabalan Also wondering if `hoodie.record.index.update.partition.path`
should be set to `true` by default, given RLI is a global index?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
