the-other-tim-brown commented on code in PR #13830:
URL: https://github.com/apache/hudi/pull/13830#discussion_r2319718995
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestDataGenerator.java:
##########
@@ -1168,11 +1181,19 @@ public Stream<HoodieRecord>
generateUniqueDeleteRecordStream(String instantTime,
* @return List of hoodie records for delete
*/
public List<HoodieRecord> generateUniqueDeleteRecords(String instantTime,
Integer n) {
- return generateUniqueDeleteRecordStream(instantTime, n,
false).collect(Collectors.toList());
+ return generateUniqueDeleteRecordStream(instantTime, n, false,
System.currentTimeMillis()).collect(Collectors.toList());
Review Comment:
Tie breaking needs to be deterministic as part of the merging logic so it
should not cause flakiness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
