danny0405 commented on code in PR #13830:
URL: https://github.com/apache/hudi/pull/13830#discussion_r2320684580
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -636,7 +638,7 @@ public static <R> HoodieData<HoodieRecord<R>>
tagGlobalLocationBackToRecords(
return Pair.of(incomingRecord, Option.empty());
}
});
- return shouldUpdatePartitionPath
+ return shouldUpdatePartitionPath || isMoRTable
Review Comment:
seems not right, the check there will decide whether to issue retraction
deletes for partition updates, we can not force make it true for MOR table
regardless of the config `shouldUpdatePartitionPath`, that would incur
inconsiscency semantics for COW and MOR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
