danny0405 commented on code in PR #13699:
URL: https://github.com/apache/hudi/pull/13699#discussion_r2265588763
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -430,16 +430,11 @@ private static <R> Option<HoodieRecord<R>>
mergeIncomingWithExistingRecordWithEx
//the record was deleted
return Option.empty();
}
- if (mergeResult.getRecord() == null) {
- // SENTINEL case: the record did not match and merge case and should not
be modified
+ if (mergeResult.getRecord() == null || mergeResult ==
existingBufferedRecord) {
Review Comment:
if this is only for merge into and merge into only been utilized with
EVENT_TIME merge mode, equals with buffered record is valid, otherwise, better
use record equals here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
