the-other-tim-brown commented on code in PR #13699:
URL: https://github.com/apache/hudi/pull/13699#discussion_r2265052470
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/IOUtils.java:
##########
@@ -119,6 +119,9 @@ public static Iterator<List<WriteStatus>>
runMerge(HoodieMergeHandle<?, ?, ?, ?>
"Error in finding the old file path at commit " + instantTime + "
for fileId: " + fileId);
} else {
mergeHandle.doMerge();
+ if (mergeHandle instanceof FileGroupReaderBasedMergeHandle) {
+ mergeHandle.close();
Review Comment:
Open question: Is there any reason to avoid calling close on the other merge
handles?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
