danny0405 commented on code in PR #13699:
URL: https://github.com/apache/hudi/pull/13699#discussion_r2265603497
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/FileGroupReaderBasedMergeHandle.java:
##########
@@ -156,13 +229,28 @@ private void init(CompactionOperation operation, String
partitionPath) {
fileWriter = HoodieFileWriterFactory.getFileWriter(instantTime,
newFilePath, hoodieTable.getStorage(),
config, writeSchemaWithMetaFields, taskContextSupplier, recordType);
} catch (IOException io) {
- LOG.error("Error in update task at commit {}", instantTime, io);
writeStatus.setGlobalError(io);
throw new HoodieUpsertException("Failed to initialize HoodieUpdateHandle
for FileId: " + fileId + " on commit "
+ instantTime + " on path " +
hoodieTable.getMetaClient().getBasePath(), io);
}
}
+ @Override
+ protected void populateIncomingRecordsMap(Iterator<HoodieRecord<T>>
newRecordsItr) {
+ // no op.
+ }
+
+ /**
+ * For COW merge path, lets map the incoming records to another iterator
which can be routed to {@link
org.apache.hudi.common.table.read.buffer.StreamingFileGroupRecordBufferLoader}.
+ * @param newRecordsItr
+ */
+ private void populateIncomingRecordsMapIterator(Iterator<HoodieRecord<T>>
newRecordsItr) {
+ if (!isCompaction) {
+ // avoid populating external spillable in base {@link
HoodieWriteMergeHandle)
+ this.incomingRecordsItr = new MappingIterator<>(newRecordsItr, record ->
(HoodieRecord) record);
Review Comment:
is this still needed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
