danny0405 commented on code in PR #13699:
URL: https://github.com/apache/hudi/pull/13699#discussion_r2265594143
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/FileGroupReaderBasedMergeHandle.java:
##########
@@ -90,7 +147,15 @@ public FileGroupReaderBasedMergeHandle(HoodieWriteConfig
config, String instantT
this.maxInstantTime = maxInstantTime;
this.keyToNewRecords = Collections.emptyMap();
this.readerContext = readerContext;
- this.operation = operation;
+ this.operation = Option.of(operation);
+ initRecordTypeAndCdcLogger(enginRecordType);
+ init(operation, this.partitionPath);
+ this.props = TypedProperties.copy(config.getProps());
+ this.isCompaction = true;
Review Comment:
we already have flag `preserveMetadata` to distinguish table service and
regular write, can we continue to use that? some functions like SI tracing
already relies on the flag `preserveMetadata`. And it seems clustering also
uses this constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
