lokeshj1703 commented on code in PR #13449:
URL: https://github.com/apache/hudi/pull/13449#discussion_r2157023760
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -452,6 +461,58 @@ protected HoodieRecord<T> updateFileName(HoodieRecord<T>
record, Schema schema,
return record.prependMetaFields(schema, targetSchema, metadataValues,
prop);
}
+ private void trackMetadataIndexStats(Option<HoodieKey> hoodieKeyOpt,
Option<HoodieRecord> combinedRecordOpt, Option<HoodieRecord<T>> oldRecordOpt,
boolean isDelete) {
Review Comment:
I think it is ok to be placed here. I can probably try and move it to
HoodieWriteHandle or create a superclass of HoodieWriteHandle where we can add
changes related to stats generation. But it can lead to more complexity.
All the handles have a very different logic of computing the secondary index
stats. Also we are reusing a lot of instance variables from the handle class
itself, so it would be better to place it in the handle class IMO.
What do you think @danny0405 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
