lokeshj1703 commented on code in PR #13449:
URL: https://github.com/apache/hudi/pull/13449#discussion_r2157011870


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -452,6 +461,58 @@ protected HoodieRecord<T> updateFileName(HoodieRecord<T> 
record, Schema schema,
     return record.prependMetaFields(schema, targetSchema, metadataValues, 
prop);
   }
 
+  private void trackMetadataIndexStats(Option<HoodieKey> hoodieKeyOpt, 
Option<HoodieRecord> combinedRecordOpt, Option<HoodieRecord<T>> oldRecordOpt, 
boolean isDelete) {

Review Comment:
   I am trying to move it but I am not sure if this is a good option. For 
example: there is quite a lot of computation specific to merge handle happening 
in `org.apache.hudi.io.HoodieMergeHandle#trackMetadataIndexStats`. Why do we 
need to move it to Utils class?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to