lokeshj1703 commented on code in PR #13449:
URL: https://github.com/apache/hudi/pull/13449#discussion_r2157114452


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -128,7 +132,9 @@ public HoodieMergeHandle(HoodieWriteConfig config, String 
instantTime, HoodieTab
   public HoodieMergeHandle(HoodieWriteConfig config, String instantTime, 
HoodieTable<T, I, K, O> hoodieTable,
                            Iterator<HoodieRecord<T>> recordItr, String 
partitionPath, String fileId,
                            TaskContextSupplier taskContextSupplier, 
HoodieBaseFile baseFile, Option<BaseKeyGenerator> keyGeneratorOpt) {
-    super(config, instantTime, partitionPath, fileId, hoodieTable, 
taskContextSupplier);
+    super(config, instantTime, partitionPath, fileId, hoodieTable, 
taskContextSupplier, false);
+    // The super class constructor is called with preserveMetadata as false
+    this.preserveMetadata = false;

Review Comment:
   parent class doesn't have the flag. HoodieAppendHandle does not use it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to