danny0405 commented on code in PR #13449:
URL: https://github.com/apache/hudi/pull/13449#discussion_r2155928001
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -315,16 +324,31 @@ protected void writeInsertRecord(HoodieRecord<T>
newRecord) throws IOException {
protected void writeInsertRecord(HoodieRecord<T> newRecord, Schema schema,
Properties prop)
throws IOException {
- if (writeRecord(newRecord, Option.of(newRecord), schema, prop,
HoodieOperation.isDelete(newRecord.getOperation()))) {
+ if (writeRecord(newRecord, Option.empty(), Option.of(newRecord), schema,
prop, HoodieOperation.isDelete(newRecord.getOperation()))) {
Review Comment:
can we just pass null instead of `Option.empty()` if the old record is not
there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
