TheR1sing3un commented on PR #13350: URL: https://github.com/apache/hudi/pull/13350#issuecomment-2908878817
> Good catch. Might need to be more weary of `string.format` usages in the future. IIRC, this is the third time if memory serves me right that we are fixing `String.format` usages in recent history. > > 1 was related to key generation, another was related to timeline hash computation, this is the third. It might be a good approach to uniformly modify all the places where `format` is used in the entire project. However, this could significantly reduce the readability and maintainability of the code. After all, `format` itself can provide the same effect as comments. But it is certain that for the code path of `per-record`, we should achieve the ultimate optimization -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
