TheR1sing3un commented on PR #13350: URL: https://github.com/apache/hudi/pull/13350#issuecomment-2907568243
@danny0405 @yihua Hi, Danny, yihua, thanks for your suggestions. After the above review, should we now remove these util methods and implement them at each place where these methods are called? This might lead to a considerable number of code changes and the same logic being repeatedly implemented in various places, resulting in a decline in maintainability. Should we focus on the concatenation performance of String? We can solve the performance problem simply by replacing `String#format` with `StringBuilder` without introducing more changes. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
