danny0405 commented on code in PR #13350:
URL: https://github.com/apache/hudi/pull/13350#discussion_r2106064725
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/BucketIdentifier.java:
##########
@@ -54,15 +54,30 @@ private static List<String>
getHashKeysUsingIndexFields(String recordKey, List<S
}
public static String partitionBucketIdStr(String partition, int bucketId) {
- return String.format("%s_%s", partition, bucketIdStr(bucketId));
Review Comment:
A cache would make the performance gap transparent to the invokers, I don't
think we should maintain cache for each caller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]