TheR1sing3un commented on code in PR #13350:
URL: https://github.com/apache/hudi/pull/13350#discussion_r2106060433
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/BucketIdentifier.java:
##########
@@ -54,15 +54,30 @@ private static List<String>
getHashKeysUsingIndexFields(String recordKey, List<S
}
public static String partitionBucketIdStr(String partition, int bucketId) {
- return String.format("%s_%s", partition, bucketIdStr(bucketId));
Review Comment:
> Does it make sense we add a cache for it, just like what we do to `avro
schema string -> schema` conversion.
The performance of using `StringBuilder` is already sufficient to eliminate
the hotspots on the flame graph. It seems that introducing cache has no more
advantages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
