danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2084437238
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableRollback.java:
##########
@@ -1014,14 +1018,9 @@ void
testInsertsGeneratedIntoLogFilesRollbackAfterCompaction(boolean rollbackUsi
// Do a compaction
newCommitTime =
writeClient.scheduleCompaction(Option.empty()).get().toString();
HoodieWriteMetadata<JavaRDD<WriteStatus>> compactionMetadata =
writeClient.compact(newCommitTime);
- statuses = compactionMetadata.getWriteStatuses();
- // Ensure all log files have been compacted into base files
- String extension = table.getBaseFileExtension();
- Collection<List<HoodieWriteStat>> stats =
compactionMetadata.getCommitMetadata().get().getPartitionToWriteStats().values();
- assertEquals(numLogFiles,
stats.stream().flatMap(Collection::stream).filter(state ->
state.getPath().contains(extension)).count());
- assertEquals(numLogFiles,
stats.stream().mapToLong(Collection::size).sum());
-
- //writeClient.commitCompaction(newCommitTime, statuses, Option.empty());
+ writeClient.commitCompaction(newCommitTime, compactionMetadata,
Option.empty());
+
assertTrue(metaClient.reloadActiveTimeline().filterCompletedInstants().containsInstant(newCommitTime));
Review Comment:
The validation for write stats is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
