danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2084418060
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestGlobalIndexEnableUpdatePartitions.java:
##########
@@ -112,41 +111,41 @@ public void testPartitionChanges(HoodieTableType
tableType, IndexType indexType)
String commitTimeAtEpoch0 = getCommitTimeAtUTC(0);
List<HoodieRecord> insertsAtEpoch0 = getInserts(totalRecords, p1, 0,
payloadClass);
client.startCommitWithTime(commitTimeAtEpoch0);
- assertNoWriteErrors(client.upsert(jsc().parallelize(insertsAtEpoch0, 2),
commitTimeAtEpoch0).collect());
+ client.commit(commitTimeAtEpoch0,
client.upsert(jsc().parallelize(insertsAtEpoch0, 2), commitTimeAtEpoch0));
// 2nd batch: normal updates same partition
String commitTimeAtEpoch5 = getCommitTimeAtUTC(5);
List<HoodieRecord> updatesAtEpoch5 = getUpdates(insertsAtEpoch0, 5,
payloadClass);
client.startCommitWithTime(commitTimeAtEpoch5);
- assertNoWriteErrors(client.upsert(jsc().parallelize(updatesAtEpoch5, 2),
commitTimeAtEpoch5).collect());
+ client.commit(commitTimeAtEpoch5,
client.upsert(jsc().parallelize(updatesAtEpoch5, 2), commitTimeAtEpoch5));
readTableAndValidate(metaClient, new int[] {0, 1, 2, 3}, p1, 5);
// 3rd batch: update all from p1 to p2
String commitTimeAtEpoch6 = getCommitTimeAtUTC(6);
List<HoodieRecord> updatesAtEpoch6 = getUpdates(updatesAtEpoch5, p2, 6,
payloadClass);
client.startCommitWithTime(commitTimeAtEpoch6);
- assertNoWriteErrors(client.upsert(jsc().parallelize(updatesAtEpoch6, 2),
commitTimeAtEpoch6).collect());
+ client.commit(commitTimeAtEpoch6,
client.upsert(jsc().parallelize(updatesAtEpoch6, 2), commitTimeAtEpoch6));
readTableAndValidate(metaClient, new int[] {0, 1, 2, 3}, p2, 6);
// 4th batch: update all from p2 to p3
String commitTimeAtEpoch7 = getCommitTimeAtUTC(7);
List<HoodieRecord> updatesAtEpoch7 = getUpdates(updatesAtEpoch6, p3, 7,
payloadClass);
client.startCommitWithTime(commitTimeAtEpoch7);
- assertNoWriteErrors(client.upsert(jsc().parallelize(updatesAtEpoch7, 2),
commitTimeAtEpoch7).collect());
+ client.commit(commitTimeAtEpoch7,
client.upsert(jsc().parallelize(updatesAtEpoch7, 2), commitTimeAtEpoch7));
readTableAndValidate(metaClient, new int[] {0, 1, 2, 3}, p3, 7);
// 5th batch: late update all to p4; discarded
String commitTimeAtEpoch8 = getCommitTimeAtUTC(8);
List<HoodieRecord> updatesAtEpoch2 = getUpdates(insertsAtEpoch0, p4, 2,
payloadClass);
client.startCommitWithTime(commitTimeAtEpoch8);
- assertNoWriteErrors(client.upsert(jsc().parallelize(updatesAtEpoch2, 2),
commitTimeAtEpoch8).collect());
Review Comment:
`assertNoWriteErrors` check is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
