danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2084403939
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java:
##########
@@ -272,34 +273,34 @@ public void testTurnOffMetadataIndexAfterEnable() throws
Exception {
HoodieWriteConfig cfg = getConfigBuilder(TRIP_EXAMPLE_SCHEMA,
HoodieIndex.IndexType.BLOOM, HoodieFailedWritesCleaningPolicy.EAGER)
.withParallelism(1,
1).withBulkInsertParallelism(1).withFinalizeWriteParallelism(1).withDeleteParallelism(1)
.withConsistencyGuardConfig(ConsistencyGuardConfig.newBuilder().withConsistencyCheckEnabled(true).build())
-
.withMetadataConfig(HoodieMetadataConfig.newBuilder().enable(true).build())
+
.withMetadataConfig(HoodieMetadataConfig.newBuilder().enable(true).withMetadataIndexColumnStats(false).build())
.build();
- init(COPY_ON_WRITE);
+ init(COPY_ON_WRITE, Option.of(cfg), true, false, false);
HoodieSparkEngineContext engineContext = new HoodieSparkEngineContext(jsc);
// metadata enabled with only FILES partition
try (SparkRDDWriteClient client = new SparkRDDWriteClient(engineContext,
cfg)) {
// Insert
String commitTime = "0000001";
List<HoodieRecord> records = dataGen.generateInserts(commitTime, 20);
client.startCommitWithTime(commitTime);
- List<WriteStatus> writeStatuses = client.insert(jsc.parallelize(records,
1), commitTime).collect();
- assertNoWriteErrors(writeStatuses);
Review Comment:
`assertNoWriteErrors` is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
