danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2084416203
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/TestMultiWriterWithPreferWriterIngestion.java:
##########
@@ -242,19 +243,16 @@ public void
testHoodieClientMultiWriterWithClustering(HoodieTableType tableType)
private void createCommitWithInserts(HoodieWriteConfig cfg,
SparkRDDWriteClient client,
String prevCommitTime, String
newCommitTime, int numRecords) throws Exception {
- // Finish first base commmit
- JavaRDD<WriteStatus> result = insertFirstBatch(cfg, client, newCommitTime,
prevCommitTime, numRecords, SparkRDDWriteClient::bulkInsert,
+ insertFirstBatch(cfg, client, newCommitTime, prevCommitTime, numRecords,
SparkRDDWriteClient::bulkInsert,
false, false, numRecords, INSTANT_GENERATOR);
- assertTrue(client.commit(newCommitTime, result), "Commit should succeed");
}
private void createCommitWithUpserts(HoodieWriteConfig cfg,
SparkRDDWriteClient client, String prevCommit,
String commitTimeBetweenPrevAndNew,
String newCommitTime, int numRecords)
throws Exception {
- JavaRDD<WriteStatus> result = updateBatch(cfg, client, newCommitTime,
prevCommit,
+ updateBatch(cfg, client, newCommitTime, prevCommit,
Option.of(Arrays.asList(commitTimeBetweenPrevAndNew)), "000",
numRecords, SparkRDDWriteClient::upsert, false, false,
numRecords, 200, 2, INSTANT_GENERATOR);
- client.commit(newCommitTime, result);
Review Comment:
is the instant committed or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
