yihua commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2019394972
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableCompaction.java:
##########
@@ -200,11 +221,190 @@ public void testWriteLogDuringCompaction(boolean
enableMetadataTable, boolean en
client.delete(deleteRecords, client.startCommit());
// insert the same 100 records again
client.upsert(writeRecords, client.startCommit());
- Assertions.assertEquals(100, readTableTotalRecordsNum());
+ assertEquals(100, readTableTotalRecordsNum());
} finally {
jsc().hadoopConfiguration().set(HoodieReaderConfig.FILE_GROUP_READER_ENABLED.key(),
"true");
}
+ }
+
+ @ParameterizedTest
+ @CsvSource(value = {"true,true", "true,false", "false,true", "false,false"})
+ void testCompactionSchedulingWithUncommittedLogFileOrRollback(boolean
enableMetadataTable,
Review Comment:
I added the javadocs for the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
