yihua commented on PR #13007: URL: https://github.com/apache/hudi/pull/13007#issuecomment-2762209553
> hey @yihua : lets sync up f2f on > > ``` > Instead of polluting code classes with table version check and divergence of logic around log marker, could you introduce a new LogMarkerHandler or LogMarkerBuilder or MarkerBuilder depending on the abstracted logic, V1 and V2 implementation for table version 6 and 8, and use such builder or handler in core classes? In this way, in the future, it's easier to deprecate the old logic. > ``` > > lets ensure we align on your expectation to avoid back and forth. we can quickly spend 10 mins and align. > > bcoz, we have MarkerBasedRollbackStrategy which extends from BaseRollbackPlanActionExecutor.RollbackStrategy. Are you suggesting to create 2 MarkerBasedRollbackStrategy (one for v6 and another for v8). > > and similarly, we have ListingBasedRollbackStrategy as well. > > Or are you suggesting, within ListingBasedRollbackStrategy, we introduce two handlers, one for v6 and another one for v8. and move most logic inside the handle classes. It depends on the complexity of the logic and differences between v6 and v8 logic, and the goal is to make sure the code classes like the action executors contain easy-to-follow logic and table version-specific logic is hidden inside the implementation classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
