yihua commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2019109430
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##########
@@ -290,7 +290,8 @@ protected LogFileCreationCallback getLogCreationCallback() {
@Override
public boolean preFileCreation(HoodieLogFile logFile) {
WriteMarkers writeMarkers =
WriteMarkersFactory.get(config.getMarkersType(), hoodieTable, instantTime);
- return writeMarkers.createIfNotExists(partitionPath,
logFile.getFileName(), IOType.CREATE,
+ IOType ioType =
getHoodieTableMetaClient().getTableConfig().getTableVersion().lesserThan(HoodieTableVersion.EIGHT)
? IOType.APPEND : IOType.CREATE;
+ return writeMarkers.createIfNotExists(partitionPath,
logFile.getFileName(), ioType,
Review Comment:
We need a new API for create a maker for a log file without specifying the
`ioType` so that the implementation can be different using different
implemetation within `WriteMarkers` class instead of adding more complexity in
the `HoodieWriteHandle` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
