yihua commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2019455801
##########
hudi-common/src/main/java/org/apache/hudi/common/data/HoodieListPairData.java:
##########
@@ -199,6 +201,31 @@ public HoodiePairData<K, V> union(HoodiePairData<K, V>
other) {
return new HoodieListPairData<>(unionStream, lazy);
}
+ @Override
+ public <W> HoodiePairData<K, Pair<V, W>> join(HoodiePairData<K, W> other) {
+ ValidationUtils.checkArgument(other instanceof HoodieListPairData);
+
+ // Transform right-side container to a multi-map of [[K]] to [[List<W>]]
values
+ HashMap<K, List<W>> rightStreamMap = ((HoodieListPairData<K, W>)
other).asStream().collect(
+ Collectors.groupingBy(
+ Pair::getKey,
+ HashMap::new,
+ Collectors.mapping(Pair::getValue, Collectors.toList())));
+
+ List<Pair<K, Pair<V, W>>> joinResult = new ArrayList<>();
+ asStream().forEach(pair -> {
+ K key = pair.getKey();
+ V leftValue = pair.getValue();
+ List<W> rightValues = rightStreamMap.getOrDefault(key,
Collections.emptyList());
+
+ for (W rightValue : rightValues) {
+ joinResult.add(Pair.of(key, Pair.of(leftValue, rightValue)));
+ }
+ });
Review Comment:
This is always non-lazy. HUDI-9243 to improve it separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
