lokeshj1703 commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2018480935
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1143,7 +1114,6 @@ private static List<HoodieRecord>
convertMetadataToRollbackRecords(HoodieRollbac
HoodieTableMetaClient dataTableMetaClient) {
Map<String, Map<String, Long>> partitionToAppendedFiles = new HashMap<>();
processRollbackMetadata(rollbackMetadata, partitionToAppendedFiles);
- reAddLogFilesFromRollbackPlan(dataTableMetaClient, instantTime,
partitionToAppendedFiles);
Review Comment:
Please check discussion regarding it in
https://github.com/apache/hudi/pull/13007#discussion_r2017704147
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/TestHoodieMergeOnReadTable.java:
##########
@@ -605,6 +605,10 @@ public void testMetadataStatsOnCommit(Boolean
rollbackUsingMarkers) throws Excep
assertEquals(0, inserts);
assertEquals(200, upserts);
+ if (!rollbackUsingMarkers) {
+ // we can do listing based rollback only when commit is completed
+ assertTrue(client.commit(instant2, statuses), "Commit should succeed");
Review Comment:
Please check discussion regarding it in
https://github.com/apache/hudi/pull/13007#discussion_r2017704147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
