tengqm commented on code in PR #6469:
URL: https://github.com/apache/gravitino/pull/6469#discussion_r1968731693
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -48,6 +48,12 @@ private Configs() {}
public static final String ENTITY_RELATIONAL_JDBC_BACKEND_PASSWORD_KEY =
"gravitino.entity.store.relational.jdbcPassword";
+ public static final String
ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION_KEY =
+ "gravitino.entity.store.relational.max.total.connection";
Review Comment:
Okay. If this is a "config option", then following the established naming
style makes sense. If it is the key for an exposed metrics, we'd better follow
the industry practices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
