TEOTEO520 commented on code in PR #6469:
URL: https://github.com/apache/gravitino/pull/6469#discussion_r1967968487
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -48,6 +48,12 @@ private Configs() {}
public static final String ENTITY_RELATIONAL_JDBC_BACKEND_PASSWORD_KEY =
"gravitino.entity.store.relational.jdbcPassword";
+ public static final String
ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION_KEY =
+ "gravitino.entity.store.relational.max.total.connection";
Review Comment:
> > For last segment, we should use camel style. We should use
`maxTotalConnection` at least.
>
> No. For metrics, we don't known what software people are using to consume
them. There is a possibility that software is not case sensitive.
Agree, most metrics use Dot-separated Naming Convention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
