Re: [PR] [#6467] improve(core): Allow JDBC backend configs be configurable [gravitino]

[via GitHub]

tengqm commented on code in PR #6469:
URL: https://github.com/apache/gravitino/pull/6469#discussion_r1970730379


##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -137,6 +147,21 @@ private Configs() {}
           .stringConf()
           .createWithDefault(DEFAULT_RELATIONAL_JDBC_BACKEND_PASSWORD);
 
+  public static final ConfigEntry<Integer> 
ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION =
+      new 
ConfigBuilder(ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION_KEY)

Review Comment:
   ```suggestion
         new ConfigBuilder(ENTITY_RELATIONAL_JDBC_BACKEND_MAX_CONNECTION_KEYS)
   ```



##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -84,6 +90,10 @@ private Configs() {}
 
   public static final String DEFAULT_RELATIONAL_JDBC_BACKEND_PASSWORD = 
"gravitino";
 
+  public static final int DEFAULT_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION 
= 100;

Review Comment:
   ```suggestion
     public static final int DEFAULT_RELATIONAL_JDBC_BACKEND_MAX_CONNECTIONS = 
100;
   ```



##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -137,6 +147,21 @@ private Configs() {}
           .stringConf()
           .createWithDefault(DEFAULT_RELATIONAL_JDBC_BACKEND_PASSWORD);
 
+  public static final ConfigEntry<Integer> 
ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION =
+      new 
ConfigBuilder(ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION_KEY)
+          .doc("The maximum number of connections for the JDBC Backend 
connection pool")
+          .version(ConfigConstants.VERSION_0_9_0)
+          .intConf()
+          
.createWithDefault(DEFAULT_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION);
+
+  public static final ConfigEntry<Long> 
ENTITY_RELATIONAL_JDBC_BACKEND_MAX_WAIT_MILLIS_CONNECTION =

Review Comment:
   ```suggestion
     public static final ConfigEntry<Long> 
ENTITY_RELATIONAL_JDBC_BACKEND_WAIT_MILLISECONDS =
   ```



##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -84,6 +90,10 @@ private Configs() {}
 
   public static final String DEFAULT_RELATIONAL_JDBC_BACKEND_PASSWORD = 
"gravitino";
 
+  public static final int DEFAULT_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION 
= 100;
+
+  public static final long 
DEFAULT_RELATIONAL_JDBC_BACKEND_MAX_WAIT_MILLIS_CONNECTION = 1000L;

Review Comment:
   ```suggestion
     public static final long 
DEFAULT_RELATIONAL_JDBC_BACKEND_MAX_WAIT_MILLISECONDS = 1000L;
   ```



##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -137,6 +147,21 @@ private Configs() {}
           .stringConf()
           .createWithDefault(DEFAULT_RELATIONAL_JDBC_BACKEND_PASSWORD);
 
+  public static final ConfigEntry<Integer> 
ENTITY_RELATIONAL_JDBC_BACKEND_MAX_TOTAL_CONNECTION =

Review Comment:
   ```suggestion
     public static final ConfigEntry<Integer> 
ENTITY_RELATIONAL_JDBC_BACKEND_MAX_CONNECTIONS =
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org